Quick check for undefined s4

[niktek]

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

As commented on #6887 the stripping fails for our project https://github.com/Brain-Bones/skeleton. We are not doing anything with application/ that that ticket is trying to remedy, but I can't see a way to figure out which file is making this fail. This is a simple fix that makes packaging work for us again.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 874945a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dummdidumm]

Thank you - sorry for the oversight in the original PR. Could you add a changeset (run npx changeset in the monorepo root and follow the prompts)? Then we're good to merge.

[niktek]

Hi,

Actually - please don't merge this yet. I think it might be affecting the resultant tarballs (is this even possible ?).

I'm getting  EACCES  EACCES: permission denied, open '/Users/nik/Library/pnpm/store/v3/file+brainandbones-skeleton-0.37.32.tgz/tarball-integrity' when trying to install any generated package now.

Investigating further:

If the strip_lang_tags function is modified to:

export function strip_lang_tags(content) {
	return content
}

Then the generated tarball is fine. I'm suspecting something like the tarball stream writer writing the original string length but then writing the output from this function that stripped the string and changed its length ?

Further testing with a brand new SK lib and it generates a good tarball. Have added a select few components from SkeletonUI and that also generates a good tarball. So there is still something somewhere in our full project that still gets broken by next.4, but this PR is still going to be needed.

[dummdidumm]

Alright, merging this - the tarball thing sounds really weird and maybe unrelated, I can't imagine why such a code change would create a broken tarball.