Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] warn if svelte not found in dependencies or peerDependencies #7685

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

benmccann
Copy link
Member

This allows vite-plugin-svelte to detect which libraries are Svelte libraries

@benmccann benmccann added the pkg:svelte-package Issues related to svelte-package label Nov 16, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

🦋 Changeset detected

Latest commit: 54f96fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to just do !pkg.dependencies?.svelte && !pkg.peerDependencies?.svelte, right? We don't need to iterate through all of the keys in the objects.

@benmccann
Copy link
Member Author

duh. thank you!

@dummdidumm
Copy link
Member

wow Github playing tough, @Conduitry you need to approve as well since you requested changes, else we can't merge 😅

@benmccann benmccann merged commit 689f6d0 into master Nov 16, 2022
@benmccann benmccann deleted the svelte-deps branch November 16, 2022 19:18
@benmccann
Copy link
Member Author

doesn't stop you if you're an admin I guess 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:svelte-package Issues related to svelte-package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants