-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] warn if svelte not found in dependencies or peerDependencies #7685
Conversation
🦋 Changeset detectedLatest commit: 54f96fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to just do !pkg.dependencies?.svelte && !pkg.peerDependencies?.svelte
, right? We don't need to iterate through all of the keys in the objects.
ba713f1
to
97fe5cd
Compare
duh. thank you! |
wow Github playing tough, @Conduitry you need to approve as well since you requested changes, else we can't merge 😅 |
doesn't stop you if you're an admin I guess 😆 |
This allows
vite-plugin-svelte
to detect which libraries are Svelte libraries