Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: Right Click Char to Whisper Does not Work #49

Open
nitoygo opened this issue Oct 23, 2024 · 1 comment
Open

Chat: Right Click Char to Whisper Does not Work #49

nitoygo opened this issue Oct 23, 2024 · 1 comment

Comments

@nitoygo
Copy link
Collaborator

nitoygo commented Oct 23, 2024

Describe the bug
Right clicking another character to put name in whisper target does not work

To Reproduce
Steps to reproduce the behavior:

  1. Login Player1 Player2
  2. In Player1's screen, press enter to show the chat input box
  3. Right click on Player2
  4. Notice that the name of Player2 is not copied to the target name for whisper
    image

Expected behavior
Right clicking another character should copy the name

Note
Right clicking on the name on the chat history works, but not when right clicking on char itself

@nitoygo
Copy link
Collaborator Author

nitoygo commented Jan 18, 2025

From the code, it seems LBUTTON is used. Can anybody confirm if it should be left click or right click?

    auto const releaseMouse = SEASON3B::IsRelease(VK_LBUTTON);

    if (SelectedCharacter >= 0 && (IsVisible() && releaseMouse))
    {
        auto const character = &CharactersClient[SelectedCharacter];

        if (character->Object.Kind == KIND_PLAYER
            && !gMapManager.InChaosCastle()
            && !(::IsStrifeMap(gMapManager.WorldActive)
                && Hero->m_byGensInfluence != character->m_byGensInfluence))
        {
            SetWhsprID(character->ID);
        }
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant