Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OVERWRITE_FILES env var is not prefixed #1457

Closed
lahwaacz opened this issue Oct 9, 2024 · 1 comment
Closed

OVERWRITE_FILES env var is not prefixed #1457

lahwaacz opened this issue Oct 9, 2024 · 1 comment

Comments

@lahwaacz
Copy link
Contributor

lahwaacz commented Oct 9, 2024

A small nitpick: the OVERWRITE_FILES environment variable is not prefixed with MINISERVE_:

miniserve/src/args.rs

Line 198 in 873d485

#[arg(short = 'o', long = "overwrite-files", env = "OVERWRITE_FILES")]

Easy to fix, but I have no idea about the migration options...
@svenstaro
Copy link
Owner

Thanks for reporting this! The migration path is fairly easy pre-v1.0 :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svenstaro @lahwaacz