Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--key does not work with videowmark #23

Closed
DashLt opened this issue Oct 5, 2022 · 1 comment
Closed

--key does not work with videowmark #23

DashLt opened this issue Oct 5, 2022 · 1 comment

Comments

@DashLt
Copy link

DashLt commented Oct 5, 2022

Hello!

Thank you for this excellent program. I've encountered an issue when trying to add a watermark with a key.

The command & output:

videowmark add --key filename.key /source/path /dest/path message
Audio Codec:  -c:a aac -ab 193247
audiowmark: unsupported global option '--key' (use audiowmark -h)
videowmark: error: watermark generation failed (audiowmark)

Looking at the videowmark code, it seems that the key is being added to the global args:
--key ) AUDIOWMARK_ARGS+=("--key" "$2"); shift 2 ;;

A possible solution would be to add a separate variable for after-command args. I will try to do this later and open a PR, though my bash is not very good...

@swesterfeld
Copy link
Owner

Thanks, should be fixed by eced66f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants