MsgGpsTime implementation of gps_time is not checking status flags

[marcomaida94]

Hello,
I have experienced some inconsistency in MsgGpsTime

{"crc":11885,"length":11,"msg_type":258,"msg_name":"MSG_GPS_TIME","payload":"AADM7g0AAAAAAAA=","preamble":85,"sender":789,"wn":0,"tow":913100,"ns_residual":0,"flags":0}

As you can see here, week number is zero (this data is recent) and the flags field is also 0, which is supposed to communicate that the message is invalid. By reading the docs:

However, the gps_time function does not check for this flag, and when called it returns an invalid timestamp for the above case.

Should the function be fixed and return None if the status flag is 0?

Thank you!

[silverjam]

Hello @marcomaida94 -- we're discussing this internally, we should have a response for you soon. Thanks for raising the issue!

[marcomaida94]

Thank you @silverjam for the quick reply !

[pcrumley]

Hi @marcomaida94 -- Thanks for bringing this issue to our attention. It should be closed by PR: #1375

[marcomaida94]

Thank you!