simplify bootstrap build #5939
Merged
simplify bootstrap build #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
feature/bootstrap-minimal-build
branch
2 times, most recently
from
ec5fa8f to
0d84fd3
Compare
|
@swift-ci smoke test |
motivation: remove depednecy on workspace that carries over dependencies on source control and registry changes: * move minimal-built-tool code into swift-bootstrap * add dependency resolution code swift-bootstrap so it does not require dependency on workspace * cleanup bootstrap arguments for those that can be hard coded * adjust target dependencies and cmake setup accordingly
tomerd
force-pushed
the
feature/bootstrap-minimal-build
branch
from
0d84fd3 to
3fed667
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
🎉 |
|
Toolchain build passed ✅ |
neonichu
reviewed
Dec 2, 2022
| @@ -229,8 +229,8 @@ public struct BuildParameters: Encodable { | |||
| hostTriple: Triple? = nil, | |||
| destinationTriple: Triple? = nil, | |||
| archs: [String] = [], | |||
| flags: BuildFlags, | |||
| xcbuildFlags: [String] = [], | |||
| flags: BuildFlags = .init(), | |||
There was a problem hiding this comment.
Was this intentional? So far it seems like this was explicit.
neonichu
approved these changes
Dec 2, 2022
|
@swift-ci please smoke test |
|
hmm does not seem to be related? |
|
@swift-ci please smoke test linux |
1 similar comment
|
@swift-ci please smoke test linux |
Azoy
pushed a commit
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: remove depednecy on workspace that carries over dependencies on source control and registry
changes: