Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround an issue regarding libXCTest.so #5952

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Workaround an issue regarding libXCTest.so #5952

merged 1 commit into from
Dec 8, 2022

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Dec 7, 2022

We're seeing an issue where the XCTest library doesn't use absolute paths to link dependent Swift libs on Linux which means we need to explicitly set LD_LIBRARY_PATH to work around that.

@neonichu neonichu requested a review from abertelrud as a code owner December 7, 2022 04:04
@neonichu neonichu self-assigned this Dec 7, 2022
@neonichu neonichu requested review from tomerd and elsh as code owners December 7, 2022 04:04
@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

Hm, interesting, this worked locally as a workaround for the issue but doesn't seem to work in CI.

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

Hm, I see a value for LD_DEBUG but the value for LD_LIBRARY_PATH seems to be missing

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

Huh, there's some odd behavior here, I added . to the search path and now it appears to be used, but the first component of the search path is still being ignore? 🤔

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu neonichu mentioned this pull request Dec 7, 2022
Merged
@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test linux

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

Hah, we fixed self-hosted tests now, but we broke the smoke tests, because they set the search paths via bootstrap -- we need to merge any existing value from env with the custom ones we're adding.

@neonichu
Workaround an issue regarding libXCTest.so
92a176b 
We're seeing an issue where the XCTest library doesn't use absolute paths to link dependent Swift libs on Linux which means we need to explicitly set `LD_LIBRARY_PATH` to work around that.
@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test

This was referenced Dec 7, 2022
Closed
Merged
@neonichu
Copy link
Contributor Author

neonichu commented Dec 7, 2022

@swift-ci please smoke test macOS

@neonichu
Copy link
Contributor Author

neonichu commented Dec 8, 2022

Both linux smoke tests and self hosted passed now 🥳

@neonichu neonichu enabled auto-merge (squash) December 8, 2022 00:05
@neonichu neonichu merged commit 5700473 into main Dec 8, 2022
@neonichu neonichu deleted the pass-library-path branch December 8, 2022 00:57
@bnbarham bnbarham mentioned this pull request Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsh elsh elsh approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@tomerd tomerd Awaiting requested review from tomerd

Assignees

@neonichu neonichu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neonichu @elsh