Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self Code Review #27

Open
ooffordable opened this issue Nov 21, 2018 · 0 comments
Open

Self Code Review #27

ooffordable opened this issue Nov 21, 2018 · 0 comments

Comments

@ooffordable
Copy link
Contributor

  1. Complexity
  • service나 mock class 등을 폴더로 정리해야 한다.
  • service와 component에 구현한 함수들의 기준을 좀 더 명확히 통일해야 한다.
  1. Design
  • User class가 문제적이다. 현재 employee, employer 두 가지의 형태로 두번 받아오는데, 한번에 elegant하게 해야할 거 같아요
  1. Miscellonous
  • 변수이름 통일이 되어 있지 않다
  • Enum을 다루는게 문제가 많다. enum을 루프로 돌리는 방법에 대해 고민해봐야 한다.
  1. Testing
  • CI 해야지....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant