-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation metadata has negative value for number_of_orbits #114
Comments
Thanks for reporting this, @Cyberface. @markscheel I don't know how this number is computed, but a few points may be relevant:
import sxs
import matplotlib.pyplot as plt
sim = sxs.load("SXS:BBH:3683", extrapolation="Outer")
horizons = sim.horizons
plt.plot(horizons.A.time, horizons.A.coord_center_inertial)
plt.plot(horizons.B.time, horizons.B.coord_center_inertial, ls="dashed")
plt.plot(horizons.C.time, horizons.C.coord_center_inertial, ls="dotted")
plt.legend(["$A_x$", "$A_y$", "$A_z$", "$B_x$", "$B_y$", "$B_z$", "$C_x$", "$C_y$", "$C_z$"])
plt.xlabel("Time ($M$)") plt.semilogy(h.t, h.abs)
plt.xlabel("Time ($M$)")
plt.ylabel(r"$|h_{\ell,m}|$") |
This simulation was run in 2015 and uploaded to the catalog in 2019. I flagged it as public in 2024, along with many other simulations that we found in the catalog and were not yet flagged as public for some reason. Nowadays, the process of uploading a simulation to the catalog does various sanity checks including looking for missing chunks of data. Most of those sanity checks were not present in 2019, so this run fell through the cracks. The missing chunks of data usually were the result of filesystem issues on the cluster (including partial filesystem purges by sysadmins), or human error (in 2019 some people still concatenated their data sets by hand). I am flagging this simulation as deprecated. The missing chunks of data occur in all resolutions. |
Also just noticed that SXS:BBH:3664 doesn't seem to have a merger either |
Thanks for pointing these out, Sebastian. We'll be going through all of these runs, actually looking at plots for every waveform, before our next release of the catalog. I did this for our previous paper, but neglected to do so for the little data release a few months ago that was kind of a test for our next big release. I just assumed we had worked out the kinks in our data archiving process... |
No worries, sorry to be annoying! I really appriciate the work the SXS colab are doing and look forward to the next big release! |
Oh, not at all. I really appreciate it. Thanks again! |
Hi,
I noticed that the
number_of_orbits
in the metadata for the SXS:BBH:3683 simulation has a negative value.Not sure if this is the best place to put this but hopefully it's helpful!
Cheers!
The text was updated successfully, but these errors were encountered: