Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving a waveform with negative times via sxs.rpdmb.save and then loading it yields a waveform with the negative times removed #116

Open
keefemitman opened this issue Nov 1, 2024 · 2 comments

Comments

@keefemitman
Copy link
Contributor

h = sxs.load("SXS:BBH:0305).h
h_prime = h.copy()
h_prime.t -= 1000
sxs.rpdmb.save(h_prime, "test")
h_prime = sxs.load("test")
h_prime.t.size == h.t.size # this returns False
@keefemitman keefemitman changed the title saving a waveform with negative times via sxs.rpdmb.save and then loading it has the negative times removed saving a waveform with negative times via sxs.rpdmb.save and then loading it yields a waveform with the negative times removed Nov 1, 2024
@moble
Copy link
Member

moble commented Nov 1, 2024

Yeah, this is because we decided to automatically drop times before zero by default. (In fact, I thought the suggestion came from you...) If you want to keep them around, you need to pass the kwarg drop_times_before="begin".

@keefemitman
Copy link
Contributor Author

hmm ok; this makes sense for loading waveforms from the catalog, but it seems a little counter intuitive for loading waveforms from local files, since for most analyses (e.g., surrogates) we change the waveform data to make t=0 be the time of peak luminosity flux. Can we change the default depending on where the data is being loaded from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants