-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for remote URIs #16
Comments
I unserstand the background of request. |
That's a good question, I'll investigate further and let you know! |
Another part to this question would be, what about unsaved buffers? Can those be supported at all? They don't have a file URI, but the buffer does have an ID... I looked at how atom handles trying to load a non-existent file and it fails if you try to load a file that doesn't exist either locally or remotely based on the given URI. A further measure you could try would be that if a history entry is loaded but the file fails, you could quickly run through the rest of the history and pull out all the entries that match the same file. |
There's probably a flaw in that logic. Seems that |
It is possible for the files loaded into atom to be from remote locations (such as in nuclide: http://nuclide.io/docs/features/remote/). This breaks the validation logic since there is no way to use
fs
to check for file existence!https://github.com/t9md/atom-cursor-history/blob/master/lib/entry.coffee#L41 will always return false for file URIs that look like
something://url-to-file.ext
. Could you add some logic to support remote urls? Thanks!The text was updated successfully, but these errors were encountered: