From ed318d9cbf3c359aef19da68d060398a9120fa6c Mon Sep 17 00:00:00 2001
From: "Alex(Zhaoyu) Sun" <zhaoyu.sun@salesforce.com>
Date: Mon, 16 Sep 2024 13:49:31 -0700
Subject: [PATCH 1/2] add sample for hana external oauth

---
 samples/components/oauth/saphana.okta.xml    | 77 ++++++++++++++++++++
 samples/components/oauth/snowflake.azure.xml |  2 +-
 2 files changed, 78 insertions(+), 1 deletion(-)
 create mode 100644 samples/components/oauth/saphana.okta.xml

diff --git a/samples/components/oauth/saphana.okta.xml b/samples/components/oauth/saphana.okta.xml
new file mode 100644
index 00000000..f3ff000c
--- /dev/null
+++ b/samples/components/oauth/saphana.okta.xml
@@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="utf-8"?>
+<pluginOAuthConfig>
+    <dbclass>saphana</dbclass>
+    <!-- For external configs, prefix with "custom_".  -->
+    <!-- For configs embedded in the connector package, don't prefix with "custom_".  -->
+    <oauthConfigId>custom_saphana_azure</oauthConfigId>
+    <!-- Config label added in 2023.2. Avoid if backwards compatibility is needed. -->
+    <configLabel>Okta</configLabel>
+    <clientIdDesktop>$clientID</clientIdDesktop>
+    <clientSecretDesktop>$clientSecret</clientSecretDesktop>
+    <redirectUrisDesktop>http://localhost:56666/Callback</redirectUrisDesktop>
+    <redirectUrisDesktop>http://localhost:56667/Callback</redirectUrisDesktop>
+    <redirectUrisDesktop>http://localhost:56668/Callback</redirectUrisDesktop>
+    <authUri>https://${yourOktaDomain}/oauth2/{authServerName}/v1/authorize</authUri>
+    <tokenUri>https://${yourOktaDomain}/oauth2/{authServerName}/v1/token</tokenUri>
+
+    <scopes>openid</scopes>
+    <scopes>email</scopes>
+    <scopes>profile</scopes>
+    <scopes>offline_access</scopes>
+    
+    <capabilities>
+       <!-- Depending on the Okta application, dynamic ports may not be allowed. Enable this if not allowed. -->
+        <entry>
+            <key>OAUTH_CAP_FIXED_PORT_IN_CALLBACK_URL</key>
+            <value>true</value>
+        </entry>
+        <entry>
+            <key>OAUTH_CAP_PKCE_REQUIRES_CODE_CHALLENGE_METHOD</key>
+            <value>true</value>
+        </entry>
+        <entry>
+            <key>OAUTH_CAP_REQUIRE_PKCE</key>
+            <value>true</value>
+        </entry>
+        <entry>
+            <key>OAUTH_CAP_SUPPORTS_STATE</key>
+            <value>true</value>
+        </entry>        
+        <entry>
+            <key>OAUTH_CAP_CLIENT_SECRET_IN_URL_QUERY_PARAM</key>
+            <value>true</value>
+        </entry>        
+        <entry>
+            <key>OAUTH_CAP_SUPPORTS_GET_USERINFO_FROM_ID_TOKEN</key>
+            <value>true</value>
+        </entry>        
+    </capabilities>
+    <accessTokenResponseMaps>
+        <entry>
+            <key>ACCESSTOKEN</key>
+            <value>access_token</value>
+        </entry>
+        <entry>
+            <key>REFRESHTOKEN</key>
+            <value>refresh_token</value>
+        </entry>
+        <entry>
+            <key>access-token-issue-time</key>
+            <value>issued_at</value>
+        </entry>
+        <entry>
+            <key>access-token-expires-in</key>
+            <value>expires_in</value>
+        </entry>
+        <entry>
+            <key>id-token</key>
+            <value>id_token</value>
+        </entry>
+        <!-- https://developer.okta.com/docs/api/openapi/okta-oauth/guides/overview/ -->
+        <entry>
+            <key>username</key>
+            <value>preferred_username</value>
+        </entry>
+    </accessTokenResponseMaps>
+</pluginOAuthConfig>
+
diff --git a/samples/components/oauth/snowflake.azure.xml b/samples/components/oauth/snowflake.azure.xml
index 860fc423..371b49f0 100644
--- a/samples/components/oauth/snowflake.azure.xml
+++ b/samples/components/oauth/snowflake.azure.xml
@@ -51,7 +51,7 @@
     <!-- Depending on the Azure application, dynamic ports may not be allowed. Enable this if not allowed. -->
     <entry>
       <key>OAUTH_CAP_FIXED_PORT_IN_CALLBACK_URL</key>
-      <value>false</value>
+      <value>true</value>
     </entry>
   </capabilities>
   <accessTokenResponseMaps>

From 8775103925e942bfb788543f8cb95670a604a593 Mon Sep 17 00:00:00 2001
From: "Alex(Zhaoyu) Sun" <zhaoyu.sun@salesforce.com>
Date: Tue, 17 Sep 2024 01:45:55 -0700
Subject: [PATCH 2/2] change config id

---
 samples/components/oauth/saphana.okta.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/components/oauth/saphana.okta.xml b/samples/components/oauth/saphana.okta.xml
index f3ff000c..3b1362b8 100644
--- a/samples/components/oauth/saphana.okta.xml
+++ b/samples/components/oauth/saphana.okta.xml
@@ -3,7 +3,7 @@
     <dbclass>saphana</dbclass>
     <!-- For external configs, prefix with "custom_".  -->
     <!-- For configs embedded in the connector package, don't prefix with "custom_".  -->
-    <oauthConfigId>custom_saphana_azure</oauthConfigId>
+    <oauthConfigId>custom_saphana_okta</oauthConfigId>
     <!-- Config label added in 2023.2. Avoid if backwards compatibility is needed. -->
     <configLabel>Okta</configLabel>
     <clientIdDesktop>$clientID</clientIdDesktop>