Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFSID 888124 :[SDK] Update custom start of week date functions samples #519

Merged
merged 6 commits into from
Jun 3, 2020

Conversation

saugatt
Copy link
Collaborator

@saugatt saugatt commented May 28, 2020

Remove all except the custom start of the week for date functions with localstr as the last argument. See #505 for details

Copy link
Contributor

@pvanderknyff pvanderknyff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check Annotated.tdd and full_dialect.tdd?

@rosswbrown
Copy link
Contributor

rosswbrown commented May 29, 2020

In Annotated.tdd update the formula's for the custom SOW ones to use <formula part='week'> instead of <formula> example. It would work as is today I think, but this will make it more precise.

@saugatt saugatt requested a review from rosswbrown June 3, 2020 17:01
@saugatt saugatt merged commit d3a2861 into master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants