Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for the --postcss option in the new CLI #4607

Merged
merged 3 commits into from
Jun 10, 2021
Merged

add tests for the --postcss option in the new CLI #4607

merged 3 commits into from
Jun 10, 2021

Commits on Jun 10, 2021

  1. add tests for the --postcss option in the new CLI

    @RobinMalfait
    RobinMalfait committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    8b36951 View commit details
    Browse the repository at this point in the history

  2. add oneOf ability to the arg() functionality 

    By default, `arg()` doesn't have a way to define multiple types. We want
the possibility of using `--postcss` (Boolean) or `--postcss
./custom-path.js`. But by default this is not possible.

This commit will allow us to do a few things, mainly:
- Keep the same API using the `{ type: oneOf(String, Boolean), description: '...' }`
- Keep the `--help` output similar

What we did behind the scenes is make sure to put the non recognized
flags in the `_` arguments list. This is possible by doing `permissive:
true`. We then manually parse those and resolve the correct value.
    @RobinMalfait
    RobinMalfait committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    a8a36c9 View commit details
    Browse the repository at this point in the history

  3. ensure that we can use a custom --postcss ./with-custom-path.js

    @RobinMalfait
    RobinMalfait committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    55ae27a View commit details
    Browse the repository at this point in the history