Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: allow for scopes to also use autocomplete prompt #76

Closed
jromero-pg opened this issue Mar 2, 2023 · 1 comment · Fixed by #105
Closed

request: allow for scopes to also use autocomplete prompt #76

jromero-pg opened this issue Mar 2, 2023 · 1 comment · Fixed by #105
Assignees
Labels
enhancement New feature or request

Comments

@jromero-pg
Copy link

Description

Currently, only commitType uses autocomplete. In our monorepo, we have many scopes. It would be ideal to also be able to filter the scopes via autocomplete.

Expected user experience:

Given "configuration.scopes" is an array and its length is greater than 0
When the user attempts to commit
Then they should be prompted with a list of scopes
And they should be able to filter the list of scopes by typing

Proposed solution

  1. Change the prompt type from list to autocomplete here:
    https://github.com/Exlint/cz-vinyl/blob/b949ffb087e617407f768ca7c34fda8b6f9ca066/src/utils/questions.ts#L40
  2. Provide a source to the prompt similar to how it's done with commit type:
    https://github.com/Exlint/cz-vinyl/blob/b949ffb087e617407f768ca7c34fda8b6f9ca066/src/utils/questions.ts#L32-L37

Alternatives considered

No response

Do you want to create a pull request?

Yes

@jromero-pg jromero-pg changed the title allow for scopes to also use autocomplete prompt request: allow for scopes to also use autocomplete prompt Mar 2, 2023
@tal-rofe tal-rofe self-assigned this Mar 2, 2023
@roy-shiloh roy-shiloh added the enhancement New feature or request label Mar 4, 2023
@tal-rofe tal-rofe linked a pull request Apr 15, 2023 that will close this issue
13 tasks
@tal-rofe
Copy link
Owner

@jromero-pg
Supported from version 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants