move CLOCK_REALTIME to CLOCK_MONOTONIC #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergiu128 is this the direction we want to go in? |
|
Sorry, missed it. I’m unsure if this would work 100% of the time, like when the system suspends. Also seems CLOCK MONOTONIC is susceptible to NTP skewing - I didn’t initially know this is the case. I wouldn’t go through with this as I cannot guarantee correctness. I think we should stick to the realtime clock for now and in the future use the monotonic one only for time differences on the same machine, so timer object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #63
move CLOCK_REALTIME to CLOCK_MONOTONIC