Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

Package dependency flutter_ffmpeg is a git dependency, this not allowed in published packages. #52

Closed
thejacer87 opened this issue Jul 22, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request fixed

Comments

@thejacer87
Copy link

thejacer87 commented Jul 22, 2019

Description
I'm building a package that requires the audio_lts package:

dependencies:
  flutter:
    sdk: flutter
  flutter_ffmpeg:
    git:
      url: git://github.com/tanersener/flutter-ffmpeg.git
      ref: v0.2.6
      path: packages/flutter_ffmpeg_audio_lts

But when I try to publish it, it fails saying: Package dependency flutter_ffmpeg is a git dependency, this not allowed in published packages.

Expected behavior
Custom flutter package gets published when depending on a specific package

Current behavior
Publishing package using 'flutter pub' failed because you can't depend on git source.

Screenshots
image

Environment

$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.7.8+hotfix.3, on Linux, locale en_CA.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
[✓] Android Studio (version 3.4)
[✓] Connected device (2 available)

• No issues found!

Other
Just trying to require the audio_lts and not the main package.

Edit: as expected, if i require the main package, my build fails because of the sdk version mismatch:
Manifest merger failed : uses-sdk:minSdkVersion 16 cannot be smaller than version 24 declared in library [:flutter_ffmpeg]

@tanersener tanersener self-assigned this Jul 22, 2019
@tanersener tanersener added the enhancement New feature or request label Jul 22, 2019
@tanersener
Copy link
Owner

Thanks for reporting this issue. Let me try a few things to see if a workaround is possible.

@tanersener
Copy link
Owner

Can you try specifying the package name using new instructions defined for the new v0.2.7 release?

@thejacer87
Copy link
Author

looking into it right meow

thanks for the quick response

@thejacer87
Copy link
Author

confirmed works for ios and android.

toggling audio audio-lts threw the build errors as expected, so it's definitely using those packages correctly for me.

and i was able to publish my package. thanks @tanersener !!

@tanersener
Copy link
Owner

No problem. Thank you for reporting this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request fixed
Projects
None yet
Development

No branches or pull requests

2 participants