Any plan to beautify the qrcode?

[ouzhou]

Nice job! I think it is the most cool js-qrcode lib in github!

I see the foreground & background parameter in renderer, and i want to find a way to add some logo in the center of the qrcode and change the style of the fill pattern, can you give me some suggestions?

Thanks 👍

[ouzhou]

some examples:

[obany]

Those are some cool looking QR codes!

There is no support for this kind of styling at present, I can think of a few ways you could possibly achieve this at the moment.

• Use the raw on/off array produced from the QR.generate method and then render the data yourself with your additions
• Use the output from the svg renderer and then modify the content
• Use the output from the canvas and modify that

I will mark this as a future enhancement, but it may be some time before it gets implemented.

[ouzhou]

If i want create many QR , should i use new IotaQR.QR() every time?
I know js have gc ability , but i dont know it whether cause memory leak
Here are my code

const IotaQR = require("@tangle-frost/iota-qr-lib");
function async createQR(qrid) {
  // 0 autodetect
  // 1:7% 0:15% 3:25% 2:30%
  const qr = new IotaQR.QR(0, 0);
  qr.addText(qrid);
  const qrCellData = qr.generate();
  const cellSize = 10;
  const marginSize = 40;
  const jpegRenderer = IotaQR.QRRendererFactory.instance().create("jpg");
  const imgDOM = await jpegRenderer.renderHtml(qrCellData, cellSize, marginSize);
  return imgDOM.src;
}

for(let i=0; i<10000; i++) {
  createQR(i) ;
}

[obany]

I did some memory performance testing using your code and it all looks as though everything is garbage collected correctly.

You can see that after each peak there is a drop as the gc happens and the memory usage falls to below the initial baseline before the qr codes are created.