forked from ashi009/node-fast-html-parser
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"SyntaxError: The requested module 'node-html-parser' does not provide an export named 'parse'" #160
Labels
Comments
Thanks for the report. This is a duplicate of #139 I have a fix ready. Should be released shortly. |
nonara
added a commit
to nonara/node-html-parser
that referenced
this issue
Oct 3, 2021
Added wrapper for esm over CJS module and removed nonworking separate ESM build (per advice from url below). Note: Essentially a breaking change as `exports` package.json property prevents direct import from files in dist see: https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1
nonara
added a commit
to nonara/node-html-parser
that referenced
this issue
Oct 3, 2021
Added wrapper for esm over CJS module and removed nonworking separate ESM build (per advice from url below). Note: Essentially a breaking change as `exports` package.json property prevents direct import from files in dist see: https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1
Merged
Nice! As a potentially breaking change, releasing it as a new major version's probably a good idea. |
nonara
added a commit
to nonara/node-html-parser
that referenced
this issue
Oct 3, 2021
Added wrapper for esm over CJS module and removed nonworking separate ESM build (per advice from url below). Note: Essentially a breaking change as `exports` package.json property prevents direct import from files in dist see: https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1
nonara
added a commit
to nonara/node-html-parser
that referenced
this issue
Oct 3, 2021
Added wrapper for esm over CJS module and removed nonworking separate ESM build (per advice from url below). Note: Essentially a breaking change as `exports` package.json property prevents direct import from files in dist see: https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1
Yep. That's the plan. Will post a comment in this thread when it's released. |
nonara
added a commit
to nonara/node-html-parser
that referenced
this issue
Oct 10, 2021
Added wrapper for esm over CJS module and removed nonworking separate ESM build (per advice from url below). Note: Essentially a breaking change as `exports` package.json property prevents direct import from files in dist see: https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1
Corrected in v5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Installed 4.1.5, running a project with
type: "module"
in package.json, and used the syntaximport { parse } from 'node-html-parser';
as per the README. Got this error.The text was updated successfully, but these errors were encountered: