Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before erroring, check .bowerrc for folder location #66

Closed
thataustin opened this issue May 20, 2014 · 4 comments
Closed

Before erroring, check .bowerrc for folder location #66

thataustin opened this issue May 20, 2014 · 4 comments

Comments

@thataustin
Copy link

When no directory was explicitly specified and the bower_components folder can't be found in it's usual place, I think the .bowerrc file should be checked for a folder location. If it's not specified there, the error can proceed as per normal.

@thataustin thataustin changed the title Before error'ing, consult with .bowerrc for folder location Before erroring, consult with .bowerrc for folder location May 20, 2014
@thataustin thataustin changed the title Before erroring, consult with .bowerrc for folder location Before erroring, check .bowerrc for folder location May 20, 2014
@stephenplusplus
Copy link
Member

Yes! I've been meaning to do this, but haven't been able to get around to it. Would you like to send in a PR?

@stephenplusplus
Copy link
Member

@thataustin I got antsy and tried to implement. Feel free to review and leave any thoughts. (#67)

@stephenplusplus
Copy link
Member

Merged 👍

@thataustin
Copy link
Author

@stephenplusplus looks great! I had implemented almost the same thing, but didn't get far enough in the tests to commit. The only thing I might add would be another console.log explaining where all you checked for the bower folder before you decided that you couldn't find it to make it easier for the user to fix in a case like that. But you did add it to the docs (:thumbsup:), so not too concerned if you don't :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants