We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think the project could be improved adding convenience methods to the objects instead of passing id's through the relevant services.
Examples would be:
func (r *Room) History(opt *HistoryOptions) func (r *Room) Message(msgReq *RoomMessageRequest) (*http.Response, error)
With a flow like:
room := client.Room.get("123") room.History(&hipchat.HistoryOptions{})
This could be achieved by adding the service to the struct and then create some wrapper methods.
type Room struct { ... GuestAccessURL string `json:"guest_access_url"` roomService *RoomService }
func (r *Room) History(opt *HistoryOptions) (*History, *http.Response, error) { return r.roomService.History(strconv.Itoa(r.ID), opt) }
The text was updated successfully, but these errors were encountered:
I would like to work on a PR for that but I can understand if that doesn't fit the projects vision.
Sorry, something went wrong.
No branches or pull requests
I think the project could be improved adding convenience methods to the objects instead of passing id's through the relevant services.
Examples would be:
With a flow like:
This could be achieved by adding the service to the struct and then create some wrapper methods.
The text was updated successfully, but these errors were encountered: