Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateDynamicFunction is not correct for async function prototypes #751

Closed
domenic opened this issue Dec 9, 2016 · 2 comments
Closed

CreateDynamicFunction is not correct for async function prototypes #751

domenic opened this issue Dec 9, 2016 · 2 comments

Comments

@domenic
Copy link
Member

domenic commented Dec 9, 2016

That is, the issue mentioned in #692 (comment) was never fixed.
@domenic
Copy link
Member Author

domenic commented Dec 29, 2016

You also need to fix the note:

A prototype property is automatically created for every function created using CreateDynamicFunction, to provide for the possibility that the function will be used as a constructor.

@domenic domenic reopened this Dec 29, 2016
@bterlson
Copy link
Member

It's a weird note, but I'll update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bterlson @domenic