Normative: add ArrayBuffer.prototype.{detached,transfer,transferToFixedLength} #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
10 tasks
|
This should be sequenced after #3116, as it uses AOs introduced in that PR which have been renamed and updated since the spec draft. |
|
ah ok, i didn't realize the proposal repo was missing some of the changes in the spec PR, and i based it off of the proposal repo. I'll update that as well. (it'd be nice to pull the 262 changes into the proposal repo also, before it's archived) |
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Oct 25, 2023
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Oct 25, 2023
|
@bakkot as discussed, heads up that this is failing lint because DetachArrayBuffer went from 0 to 2 internal callsites (that assert it's a normal completion), but it has external callsites that require it to be a completion. |
jmdyck
reviewed
Nov 3, 2023
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Nov 3, 2023
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Nov 3, 2023
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jan 26, 2024
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Feb 5, 2024
ljharb
added
has stage 4
bakkot
approved these changes
Feb 9, 2024
michaelficarra
approved these changes
Feb 15, 2024
bakkot
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://tc39.es/proposal-arraybuffer-transfer/