Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automatically generating Unicode property lists #193

Open
bakkot opened this issue Apr 26, 2020 · 4 comments
Open

Support automatically generating Unicode property lists #193

bakkot opened this issue Apr 26, 2020 · 4 comments

Comments

@bakkot
Copy link
Contributor

bakkot commented Apr 26, 2020

PRs like tc39/ecma262#1939 and tc39/ecma262#1896 could (and should) be done automatically as part of the tooling.

@mathiasbynens maintains a collection of npm modules which could be used for this. Note that these bump Unicode versions in minor releases, so for this use case we'd want to pin a minor version.

@bakkot
Copy link
Contributor Author

bakkot commented Apr 26, 2020

Alternatively we could commit the relevant data files to ecma262 and add an option in ecmarkup to read a data file passed in on the command line. That probably makes more sense, so that we can update the version in the spec without having to mess with ecmarkup.

@ljharb
Copy link
Member

ljharb commented Apr 26, 2020

i like passing it in; but I’d hope we don’t have to commit data to 262 to do it - couldn’t we pass the path to one of the npm packages you referenced?

@bakkot
Copy link
Contributor Author

bakkot commented Apr 26, 2020

I'm not really a fan of dynamically loading dependencies, but yes, we probably could.

@mathiasbynens
Copy link
Member

I agree that not committing data to tc39/ecma262 seems best.

I noticed this was filed as an ecmarkup issue. We could solve it as this level, or we could add a script to the package.json that outputs the *.html files containing the tables (e.g. npm run build-unicode-properties). The latter seems simpler.

Regardless of where we decide to solve this, we could use the following packages in particular to generate the tables:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants