-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new testing stage #37
Conversation
e873ccc
to
5878d83
Compare
5878d83
to
d2a072a
Compare
</ul> | ||
</td> | ||
<td>The solution is complete and no further work is possible without implementation experience, significant usage and external feedback. | ||
<td>Complete: all semantics, syntax and API are completely described | ||
<td>Limited: only those deemed critical based on implementation experience | ||
<td>Spec compliant | ||
<td>Spec compliant production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td>Spec compliant production | |
<td>Spec compliant; safe to use in production |
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we got consensus on specifically this wording, I'm going to leave it alone. I'll be submitting a follow-up PR soon with names and a refactoring of descriptions that maintains the spirit here, which will include addressing this wording.
This should be good to merge as-is. |
<li>ECMAScript editors have signed off on the current spec text | ||
</ul> | ||
</td> | ||
<td>The solution is complete and no further work is possible without feedback from tests, implementations, or usage. No changes to the proposal will be requested aside from those elicited through testing or implementation experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td>The solution is complete and no further work is possible without feedback from tests, implementations, or usage. No changes to the proposal will be requested aside from those elicited through testing or implementation experience. | |
<td>The solution is complete and no further work is possible without feedback from tests, implementations, or usage. No changes to the proposal will be requested aside from those elicited through testing, implementation, or usage experience. |
surely? given that "usage" is mentioned in the previous sentence and multiple times below.
</td> | ||
<td>The solution is complete and no further work is possible without feedback from tests, implementations, or usage. No changes to the proposal will be requested aside from those elicited through testing or implementation experience. | ||
<td>Complete: all semantics, syntax and API are completely described | ||
<td>Limited: only those resulting from new information obtained through testing or usage experience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per bakkot's comment above, this needs updating to match that suggestion if accepted
<td>The solution is complete and no further work is possible without feedback from tests, implementations, or usage. No changes to the proposal will be requested aside from those elicited through testing or implementation experience. | ||
<td>Complete: all semantics, syntax and API are completely described | ||
<td>Limited: only those resulting from new information obtained through testing or usage experience | ||
<td>Spec compliant prototypes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td>Spec compliant prototypes | |
<td>Spec-compliant prototypes |
</ul> | ||
</td> | ||
<td>The solution is complete and no further work is possible without implementation experience, significant usage and external feedback. | ||
<td>Complete: all semantics, syntax and API are completely described | ||
<td>Limited: only those deemed critical based on implementation experience | ||
<td>Spec compliant | ||
<td>Spec compliant production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td>Spec compliant production | |
<td>Spec-compliant production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though the minor suggestions would be nice and perhaps consider amending the commit to not include the eyeroll emoji 🤷♀️
Ideas for a subsequent change (another PR), with the repetition of "testing, implementation, or usage experience" we might set these as a definition for "feature adoption" (name is up for bikeshed), so we only repeat the shorter verson. E.g.: -The solution is complete and no further work is possible without feedback from tests, implementations, or usage. No changes to the proposal will be requested aside from those elicited through testing, implementation, or usage experience.
+The solution is complete and no further work is possible without feedback from tests, implementations, or usage. No changes to the proposal will be requested aside from those elicited through feature adoption.
+Feature adoption for proposals comprehends the experience observed by testing results, implementation, and/or usage. This change must not block the progress/acceptance of this PR as it only serves as cosmetic/editorial. |
These suggestions are great, but for process document changes, I don't feel comfortable merging anything other than the exact wording that was agreed upon. Unlike with how the committee delegates authority to the editor group to execute what they understand to be the committee's will, changes to this document are approved explicitly. Since I'm making a follow-up anyway, I'll incorporate these suggestions into that. But next time, please review the PR before it is approved. |
To be used as a basis for the ongoing discussion of a new stage at the upcoming TC39 meeting.