Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unref() the checkperiod timer #44

Merged
merged 1 commit into from
Jan 13, 2016
Merged

unref() the checkperiod timer #44

merged 1 commit into from
Jan 13, 2016

Conversation

dougmoscrop
Copy link
Contributor

This should prevent the process staying alive problem and no longer encourages people to use process.exit.

@dougmoscrop
Copy link
Contributor Author

Looks like you are still testing on super old node - is this something you're set on supporting? If so I could add a check to see if typeof checkTimeout.unref === 'function' and instead modify the README to mention the process hang on older versions of node (I believe pre 0.9?)

mpneuried added a commit that referenced this pull request Jan 13, 2016
unref() the checkperiod timer
@mpneuried mpneuried merged commit 5d0b89c into node-cache:master Jan 13, 2016
mpneuried pushed a commit that referenced this pull request Jan 13, 2016
- optimized travis.yml
- bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants