Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated color schemes #60

Merged
merged 6 commits into from
Aug 16, 2018
Merged

Updated color schemes #60

merged 6 commits into from
Aug 16, 2018

Conversation

dempfi
Copy link
Member

@dempfi dempfi commented Aug 8, 2018

In this PR:

  • Use ayu colours from dedicated package;
  • Updated syntax colours to match those of recent versions in sublime theme;
  • Updated ui colours to reduce contrast of unimportant parts (divider lines, activity bar icons) and improve focus on editor;

screen shot 2018-08-08 at 12 11 55

@dempfi
Copy link
Member Author

dempfi commented Aug 8, 2018

@teabyii, @pahen guys I would appreciate if you would be able to test these updates and provide feedback. I think some changes might be controversial (e.g. removal of some borders).

@pahen
Copy link
Collaborator

pahen commented Aug 8, 2018

Great work! :D Looks awesome! I'll give it a try!

@designorant
Copy link

designorant commented Aug 8, 2018

This looks amazing, particularly that bright search/selection border.

For those who want to test this version now:

On the command line:

git clone https://github.com/teabyii/vscode-ayu.git
cd vscode-ayu
git fetch origin pull/60/head:updated-colors
git checkout updated-colors
npm install
npm run build
npm run package

Then, in VSCode:

Extensions > ... > Install from VSIX... > Reload

@pahen
Copy link
Collaborator

pahen commented Aug 8, 2018

I tried it now and I really like the changes so far :) Note that you can use tab.activeBorderTop and tab.unfocusedActiveBorderTop instead of tab.activeBorder and tab.unfocusedActiveBorder to get the border on the top of the tab like the sublime theme.

screen shot 2018-08-08 at 16 17 14

@posthardcode
Copy link

posthardcode commented Aug 8, 2018

Looking pretty good, great job! When you have a chance, can you also make Python methods and dots similar to ST (bottom image)?

screen shot 2018-08-08 at 19 27 54

@dempfi
Copy link
Member Author

dempfi commented Aug 8, 2018

@nscmnto fixed :)

@skbolton
Copy link

skbolton commented Aug 9, 2018

Can we get rid of the underline for js classes? I don't remember that being in the sublime version but I could be wrong
screen shot 2018-08-08 at 10 00 41 pm

@skbolton
Copy link

skbolton commented Aug 9, 2018

Also it would be nice to get more of the reddish orange colors in to match the sublime version. I initially was doing some work on this and have screenshots at #34 highlighting a sublime/vscode comparison that I was working on

@posthardcode
Copy link

@dempfi perfect, thanks!

@dempfi
Copy link
Member Author

dempfi commented Aug 13, 2018

@skbolton I've fixed underline issue. Not sure what you mean by more "reddish orange colours". Could you please elaborate on that?

@dempfi
Copy link
Member Author

dempfi commented Aug 13, 2018

@pahen, @teabyii what is your experience so far guys? Any issues to fix?

@designorant
Copy link

I have been using it with JavaScript and React, and find all the tweaks made in this PR sublime. Thank you @dempfi!

@pahen
Copy link
Collaborator

pahen commented Aug 13, 2018

I think all changes are very nice :) I'm also using it mostly for React. The only thing I would like to change is to move the tab border to the top instead of the bottom. The original theme looks like that now right? @dempfi

@designorant
Copy link

Spoke too soon, just spotted a case with unnecessary italics:

storybook

stories.add("Default", () => {
  Object.keys(endpoints).forEach(label => {
    console.log(label);
  });

  const location = boolean("Empty location", false)
    ? null
    : encodeURIComponent(
        select(
          "Content endpoints",
          Object.keys(endpoints),
          Object.keys(endpoints)[0]
        )
      );

  return (
    <AjaxContent
      location={location}
      loadingContent={<Block text="loading..." />}
      failedContent={<Block text="failed to retrieve content" />}
    >
      <Block text="default content" />
    </AjaxContent>
  );
});

@teabyii
Copy link
Collaborator

teabyii commented Aug 14, 2018

I have tried this version, it looks very good to me. Nice job.
What about the italics @designorant mentioned, and the tab.activeBorderTop @pahen mentioned?

@skbolton
Copy link

sorry @dempfi here is a screen shot talking about the reddish orange color. This screenshot is from sublime text the mirage theme. I am referencing the require statement color. In your update this color is showing up more often but hasn't shown up yet for require/imports like it does in sublime. Thanks for updating this repo btw!

screen shot 2018-08-14 at 8 16 15 am

@skbolton
Copy link

@dempfi sorry I feel like I am being the pickiest person on this thread. I can also help on any of this and not just put it on you.
Anyway can we get the activity indicators to be one of the theme colors to help them pop more?
screen shot 2018-08-14 at 9 02 26 pm

@pahen
Copy link
Collaborator

pahen commented Aug 15, 2018

We should probably update titleBar.activeForeground to use the same colors as the sublime theme too @dempfi :)

VSCode:
screen shot 2018-08-15 at 15 08 36

Sublime:
screen shot 2018-08-15 at 15 08 53

@dempfi
Copy link
Member Author

dempfi commented Aug 15, 2018

@skbolton regarding activity bar. I think theme accent colours will make them too contrasty compared to the editor.

Regarding red color, I think we already have more of it, perhaps some improvements can be done specific to some languages in future updates;

@dempfi
Copy link
Member Author

dempfi commented Aug 15, 2018

@pahen fixed title bar foreground. I tried active top border but that didn't look good with breadcrumbs and borders. Bordering in this theme is a halfbreed between full border (active top border) and no borders (active bottom border) versions so there are some UI stuff that doesn't work like in sublime.

@designorant fixed italics

@dempfi
Copy link
Member Author

dempfi commented Aug 15, 2018

@pahen, @teabyii guys, if there are no big issues with latest updates, what do you think about merging this PR?

@teabyii teabyii merged commit 4d9cf4c into ayu-theme:master Aug 16, 2018
@teabyii
Copy link
Collaborator

teabyii commented Aug 16, 2018

Done, I will release a new version soon.

@pahen
Copy link
Collaborator

pahen commented Aug 16, 2018

Thanks for awesome improvements! @dempfi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants