-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated color schemes #60
Conversation
Great work! :D Looks awesome! I'll give it a try! |
This looks amazing, particularly that bright search/selection border. For those who want to test this version now:On the command line:
Then, in VSCode:
|
@nscmnto fixed :) |
Also it would be nice to get more of the reddish orange colors in to match the sublime version. I initially was doing some work on this and have screenshots at #34 highlighting a sublime/vscode comparison that I was working on |
@dempfi perfect, thanks! |
@skbolton I've fixed underline issue. Not sure what you mean by more "reddish orange colours". Could you please elaborate on that? |
I have been using it with JavaScript and React, and find all the tweaks made in this PR sublime. Thank you @dempfi! |
I think all changes are very nice :) I'm also using it mostly for React. The only thing I would like to change is to move the tab border to the top instead of the bottom. The original theme looks like that now right? @dempfi |
Spoke too soon, just spotted a case with unnecessary italics: stories.add("Default", () => {
Object.keys(endpoints).forEach(label => {
console.log(label);
});
const location = boolean("Empty location", false)
? null
: encodeURIComponent(
select(
"Content endpoints",
Object.keys(endpoints),
Object.keys(endpoints)[0]
)
);
return (
<AjaxContent
location={location}
loadingContent={<Block text="loading..." />}
failedContent={<Block text="failed to retrieve content" />}
>
<Block text="default content" />
</AjaxContent>
);
}); |
I have tried this version, it looks very good to me. Nice job. |
sorry @dempfi here is a screen shot talking about the reddish orange color. This screenshot is from sublime text the mirage theme. I am referencing the |
@dempfi sorry I feel like I am being the pickiest person on this thread. I can also help on any of this and not just put it on you. |
We should probably update |
@skbolton regarding activity bar. I think theme accent colours will make them too contrasty compared to the editor. Regarding red color, I think we already have more of it, perhaps some improvements can be done specific to some languages in future updates; |
@pahen fixed title bar foreground. I tried active top border but that didn't look good with breadcrumbs and borders. Bordering in this theme is a halfbreed between full border (active top border) and no borders (active bottom border) versions so there are some UI stuff that doesn't work like in sublime. @designorant fixed italics |
Done, I will release a new version soon. |
Thanks for awesome improvements! @dempfi |
In this PR: