Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPOnly and SameSite attribute to Cookie #184

Open
gjyalpha opened this issue Dec 10, 2019 · 3 comments
Open

Add HTTPOnly and SameSite attribute to Cookie #184

gjyalpha opened this issue Dec 10, 2019 · 3 comments

Comments

@gjyalpha
Copy link

The Cookie struct does not accommodate HTTPOnly and SameSite fields, described in the spec.

This makes it impossible to specify the HTTPOnly and SameSite field of a cookie. This field can be specified in the Set-Cookie HTTP header, so the Cookie struct should also support it.

@gjyalpha
Copy link
Author

A similar issue filed for Selenium WebDriver SeleniumHQ/selenium#7798

@nveeser
Copy link
Contributor

nveeser commented Mar 6, 2021

What all needs to be done here?
Can we just update the Cookie struct to contain an extra field with the correct JSON field name?

@gjyalpha
Copy link
Author

Yes, I believe we just need to update the Cookie struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants