Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managing dev/null file add and removal #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

memsharded
Copy link

Hi!

I am trying to contribute the behavior for adding/removing files, i.e. managing /dev/null.

Most likely this is a poor solution, but please let me know if some other approach is better:

  • The test suite is a bit custom, I was having duplicated tests, I finally added an "example" folder, but should be easily moved to a test
  • The system still warns about /dev/null abspath, but I wasn't confident enough to modify that part

Btw: thanks for sharing this useful library!

@memsharded
Copy link
Author

It seems some CI is failing, with Py3, but not sure related to this PR: https://travis-ci.org/techtonik/python-patch/jobs/286056242

Could you please check? Thank you!

@uilianries
Copy link

Hi @techtonik ! Could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants