Show Sidecar Names with tkn tr desc #747
Conversation
tekton-robot
added
the
size/M
|
The following is the coverage report on pkg/.
|
| @@ -64,6 +64,8 @@ func DecorateAttr(attrString, message string) string { | |||
| return fmt.Sprintf("💌 ") | |||
| case "taskruns": | |||
| return fmt.Sprintf("🗂 ") | |||
| case "sidecars": | |||
There was a problem hiding this comment.
It's gotta be a car, right? 🤷♂
There was a problem hiding this comment.
or mothercycle :D but the tiny red car is cutter imho!!
| // Pass one or more names for sidecar containers for testing with tkn tr describe. | ||
| // Replace with test builder option once https://github.com/tektoncd/pipeline/issues/2078 | ||
| // is closed. | ||
| func sidecarState(names ...string) tb.TaskRunStatusOp { |
There was a problem hiding this comment.
I think it's merged now, should we wait for a pipeline release to remove this?
| @@ -64,6 +64,8 @@ func DecorateAttr(attrString, message string) string { | |||
| return fmt.Sprintf("💌 ") | |||
| case "taskruns": | |||
| return fmt.Sprintf("🗂 ") | |||
| case "sidecars": | |||
There was a problem hiding this comment.
or mothercycle :D but the tiny red car is cutter imho!!
| @@ -80,13 +80,13 @@ func TestDecoration(t *testing.T) { | |||
| funcMap := template.FuncMap{ | |||
| "decorate": DecorateAttr, | |||
| } | |||
| aTemplate := `{{decorate "bullet" "Foo"}} {{decorate "resources" ""}}{{decorate "params" ""}}{{decorate "tasks" ""}}{{decorate "pipelineruns" ""}}{{decorate "status" ""}}{{decorate "inputresources" ""}}{{decorate "outputresources" ""}}{{decorate "steps" ""}}{{decorate "message" ""}}{{decorate "taskruns" ""}}{{decorate "red" "Red"}} {{decorate "underline" "Foo"}}` | |||
| aTemplate := `{{decorate "bullet" "Foo"}} {{decorate "resources" ""}}{{decorate "params" ""}}{{decorate "tasks" ""}}{{decorate "pipelineruns" ""}}{{decorate "status" ""}}{{decorate "inputresources" ""}}{{decorate "outputresources" ""}}{{decorate "steps" ""}}{{decorate "message" ""}}{{decorate "taskruns" ""}}{{decorate "sidecars" ""}}{{decorate "red" "Red"}} {{decorate "underline" "Foo"}}` | |||
There was a problem hiding this comment.
one day we should clean this up and make the emojis template generation and testing a bit smarter !
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of #655
This pull request adds the names of Sidecar containers associated with a TaskRun to
tkn tr desc. Unfortunately, the ContainerState is not available for Sidecars at this time, but I have a pull request for this open and may be available as soon as next release of pipeline. For now, we can at least show what sidecars are present as part of a TaskRun.Submitter Checklist
make checkmake generatedRelease Notes