Display matrix TaskRuns on the PipelineRun details page #3081
Conversation
tekton-robot
added
kind/feature
|
Timed out on CreatePipelineRun test, stuck on loading state for >3 seconds. I've already bumped the timeout for this step in #3040 Re-running for now and will need to find another approach as we can't just keep increasing the timeout. When running locally this step takes ~50ms, so it really shouldn't be taking 3+ seconds (60 times as long…) in CI. /test tekton-dashboard-unit-tests |
|
Hold for a bit so we can publish a new version of the packages with #3082. I'll unhold once that's done in the next hour or so. |
tekton-robot
added
the
do-not-merge/hold
|
Ready for review |
tekton-robot
removed
the
do-not-merge/hold
| selectedTaskId === pipelineTaskName || | ||
| (!erroredTask && !selectedTaskId && index === 0); | ||
| const selectDefaultStep = !selectedTaskId; | ||
| !hasExpandedTask && |
There was a problem hiding this comment.
Found this value tough to deconstruct. Perhaps worth adding a comment or two, or splitting up into more variables with explanatory names?
There was a problem hiding this comment.
Yeah there's a lot going on there, added comments for each branch. Let me know if that helps
Add support for displaying all TaskRuns produced by a matrix task on the PipelineRun details page. Future updates will improve the display of the matrix information making it easier to differentiate between them on the left task/step nav, and making it clearer which params are provided from the matrix.
| selectedTaskId === pipelineTaskName || | ||
| (!erroredTask && !selectedTaskId && index === 0); | ||
| const selectDefaultStep = !selectedTaskId; | ||
| !hasExpandedTask && |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Related to #2410
Add support for displaying all TaskRuns produced by a matrix task on the PipelineRun details page.
Future updates will improve the display of the matrix information making it easier to differentiate between them on the left task/step nav, and making it clearer which params are provided from the matrix.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes