-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Create
and Edit and run
features for CustomRuns
#3108
Conversation
Hi @jisoolee. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @jisoolee. We need to make sure the Dashboard is always in a releasable state, so we'll either need to hide the buttons behind some kind of feature flag (query param or localStorage), or hold this PR until the create / edit page is merged first. |
@AlanGreene Thank you for review and comment. I understand, yes I was also worrying about the release schedule (if I could not completed all the tasks before the next release). Please hold this PR until I complete the feature. |
/hold |
65a2d83
to
9c70443
Compare
Create
and Edit and run
features for CustomRuns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of code in this related to the form-based UI which we are not adding for CustomRuns. Once that's removed there may be some opportunities to simplify / cleanup the remaining code.
2a807f4
to
f942ce4
Compare
7b8003e
to
a1bdc6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still quite a bit of unused code here that needs to be removed. I've added comments to the biggest pieces.
Most of this should have been caught by the linter so I'll have to debug that to figure out why it's not reporting errors.
For now you'll have to manually review each function, variable, and state field you've added to ensure they're actually used, and remove any that are not needed. When you remove a function, for example handleSubmit
, check if there are additional functions or variables that can be cleaned up following its removal.
For tracking purposes: The issue with the linter not reporting issues was identified and resolved in #3139 |
3336cb9
to
48d0131
Compare
e823128
to
3f224c6
Compare
852e4ad
to
48e012e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/ok-to-test |
Changes
The adding
Create
andEdit and run
features for CustomRuns task and it is subdivided into 3 parts (will have 3 different commits per each part in one PR)Part1. Adding Create and Edit and run buttons
Part2. Creating a Create page + Connecting the buttons to the proper Create/EditAndRun pages
Part3. Adding test cases
Connect to #2437
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes