-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions workflow for E2E tests #3834
Conversation
Run tests for read-only and read-write mode in parallel across multiple Kubernetes versions. Upload artifacts (logs, screen recordings) in case of failure. Changes to the test script are backwards compatible so existing use such as the nightly s390x / ppc64le tests on dogfooding continue to work as expected.
70b6154
to
04b9042
Compare
# - name: Collect resources from cluster | ||
# uses: chainguard-dev/actions/kind-diag@94389dc7faf4ef9040df90498419535e1bdcb60e # main | ||
# if: ${{ failure() }} | ||
# with: | ||
# artifact-name: ${{ matrix.k8s-version }}-${{ matrix.dashboard-mode }}-logs | ||
# namespace-resources: pods,taskruns,pipelineruns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporarily disabled the kind-diag
step as that action will need to be allow-listed before we can use it.
repository: tektoncd/pipeline | ||
ref: d306d649df2dbd2badaba6a90459efd05c753d2f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referencing the setup-kind.sh script from tektoncd/pipeline for now since it's a slightly modified version of the one in tektoncd/plumbing to work with GitHub Actions by adding sudo
when updating the hosts file.
Longer term we'll have a reusable action that can be shared across the projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Run tests for read-only and read-write mode in parallel across multiple Kubernetes versions.
Upload artifacts (logs, screen recordings) in case of failure.
Changes to the test script are backwards compatible, so existing use both in local development and in nightly tests for s390x / ppc64le on dogfooding continue to work as expected.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes