Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concurrency settings for E2E to cancel old PR-triggered runs #3836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlanGreene
Copy link
Member

Changes

Define a concurrency group for the E2E workflow and configure it to cancel in progress runs when a new run is triggered.

For PRs this means that only the latest run triggered for a given PR will be completed as any in progress runs will be cancelled.

For push events to the main branch, a fallback is used (run_id) as the head_ref is only defined for PR events. This means that we will run the E2E to completion on each push event as expected.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Define a concurrency group for the E2E workflow and configure it to
cancel in progress runs when a new run is triggered.

For PRs this means that only the latest run triggered for a given PR
will be completed as any in progress runs will be cancelled.

For push events to the `main` branch, a fallback is used (`run_id`) as
the `head_ref` is only defined for PR events. This means that we will
run the E2E to completion on each push event as expected.
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from alangreene after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlanGreene AlanGreene removed the request for review from skaegi December 11, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants