Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TektonInstallerSet created have each resource twice #425

Closed
sm43 opened this issue Sep 24, 2021 · 1 comment · Fixed by #428
Closed

TektonInstallerSet created have each resource twice #425

sm43 opened this issue Sep 24, 2021 · 1 comment · Fixed by #428
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@sm43
Copy link
Member

sm43 commented Sep 24, 2021

When we read resources from ko data and create installer set, the installer set has 2 copies of each resource.

for eg,
In addons, for clustertasks, when we read clustertasks from kodata here -> it calls applyAddons
in apply addon we pass the path of the directory to common.AppendManifest(manifest, addonLocation) and it
reads all the resources at the location and returns inside the manifest obj
but the manifest has 2 copies of each resource so manifest is getting bigger.

It is probably issue with AppendManifest

To reproduce the issue

  1. install operator using make TARGET=openshfit apply` on Openshift
  2. let all profile install all components
  3. for addons there would 4 installler set created
  4. check any installer set if there are 2 instances of each resource eg. in clustertask addon-clustertask- installerset there would be 2 buildah clustertask which are same.
@sm43 sm43 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 24, 2021
@vdemeester vdemeester added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 24, 2021
@sm43
Copy link
Member Author

sm43 commented Sep 27, 2021

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants