Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build - missing dashboard files #464

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

AverageMarcus
Copy link
Contributor

Changes

Fixes #457

Adds missing change needed to build tasks from #402

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Fixes missing dashboard files

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 23, 2021
@tekton-robot
Copy link
Contributor

Hi @AverageMarcus. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2021
@sm43
Copy link
Member

sm43 commented Oct 25, 2021

/ok-to-test
/lgtm

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2021
@sm43
Copy link
Member

sm43 commented Oct 25, 2021

could you also update

 if [[ ${releaseFileName} != "interceptors.notags" ]] ; then
          rm -rf ${comp_dir}/*
 fi

with

if [[ ${releaseFileName} != "interceptors" ]] ; then

@nikhil-thomas we need to find a way to keep this script in sync 🤔

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@nikhil-thomas
Copy link
Member

@nikhil-thomas we need to find a way to keep this script in sync thinking

absolutely.
in a separte pr, let us make this task use workspace to mount the operaotr code base and get the script from it, instead of having to write the script in the Task definiton.

eg: https://github.com/openshift/tektoncd-operator/blob/506f627a115454c223fa1533bce7464b8ad26cc9/openshift/release/nightly-ci-run.yaml#L68

I have created this issue to capture this #465

@nikhil-thomas
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@tekton-robot tekton-robot merged commit 13c0878 into tektoncd:main Oct 25, 2021
@vdemeester
Copy link
Member

@sm43 @nikhil-thomas we need to cherry-pick this into the release's branch and do a bugfix release 👼🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operator v0.50.0 enalbe tekton-dashboard fail.
5 participants