Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] 0.50.x Improving TektonAddon upgrade #615

Merged
merged 2 commits into from
Feb 5, 2022
Merged

[cherry-pick] 0.50.x Improving TektonAddon upgrade #615

merged 2 commits into from
Feb 5, 2022

Conversation

nikhil-thomas
Copy link
Member

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 4, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 4, 2022
@nikhil-thomas
Copy link
Member Author

/hold
pending e2e tests verification on OpenShift

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektoninstallerset/install.go 54.7% 32.1% -22.6

@nikhil-thomas nikhil-thomas force-pushed the cherry-pick/addon-upgrade branch from 01fac11 to eedee34 Compare February 4, 2022 14:27
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektoninstallerset/install.go 54.7% 32.1% -22.6

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
@nikhil-thomas nikhil-thomas force-pushed the cherry-pick/addon-upgrade branch 4 times, most recently from 7b87a90 to 54f4812 Compare February 5, 2022 09:04
@nikhil-thomas
Improve Operator upgrade mechanism
7c21ca5 
Improve ReadyChecks for Pipelines and Triggers

Add mechanism to detect upgrade scenario in reconcilers and update
status with relevant messages

Minor fixes to ensure TektonAddon reconciler acts more predictably

Signed-off-by: Nikhil Thomas <[email protected]>
(cherry picked from commit e8f205b)
@nikhil-thomas nikhil-thomas force-pushed the cherry-pick/addon-upgrade branch from 54f4812 to 7c21ca5 Compare February 5, 2022 09:35
@nikhil-thomas
Copy link
Member Author

🧑‍💻 👉 hold until we verify whether we need tektoncd/pipeline#4269 in the tektoncd/pipeline release (v0.28.x) we ship with v0.50.x (1.6.x)

@nikhil-thomas
Copy link
Member Author

nevermind it is handled as part of create-release-branch script in midstream openshift@fadfbe4

so removing hold

@nikhil-thomas
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2022
@concaf
Copy link
Contributor

concaf commented Feb 5, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2022
@tekton-robot tekton-robot merged commit c4246f2 into tektoncd:release-v0.50.x Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@sm43 sm43 Awaiting requested review from sm43

Assignees

@concaf concaf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikhil-thomas @tekton-robot @concaf @vdemeester @savitaashture