tests: fix potential races with t.Parallel and loops ➿

Following the CommonMistake[1] in Go, for loop and go routines can be
a big racey problem. This happens quite easily when using `t.Parallel`
in for loop with tests.

This fixes possible races by adding a "shadow" var that is evaluated
at each iteration and placed on the stack for the goroutine, so each
slice element is available to the goroutine when it is eventually
executed.

[1]: https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables

Signed-off-by: Vincent Demeester <[email protected]>

pkg/reconciler/pipelinerun/resources/apply_test.go

@@ -247,6 +247,7 @@ func TestApplyParameters(t *testing.T) {
 			}},
 		},
 	}} {
+		tt := tt // capture range variable
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			run := &v1beta1.PipelineRun{

test/cancel_test.go

@@ -41,6 +41,7 @@ func TestTaskRunPipelineRunCancel(t *testing.T) {
 	// on failure, to ensure that cancelling the PipelineRun doesn't cause
 	// the retrying TaskRun to retry.
 	for _, numRetries := range []int{0, 1} {
+		numRetries := numRetries // capture range variable
 		t.Run(fmt.Sprintf("retries=%d", numRetries), func(t *testing.T) {
 			ctx := context.Background()
 			ctx, cancel := context.WithCancel(ctx)

test/examples_test.go

@@ -218,6 +218,7 @@ func TestExamples(t *testing.T) {
 
 	t.Parallel()
 	for _, path := range getExamplePaths(t, baseDir) {
+		path := path // capture range variable
 		testName := extractTestName(baseDir, path)
 		waitValidateFunc := waitValidatePipelineRunDone
 		kind := "pipelinerun"

test/git_checkout_test.go

@@ -96,6 +96,7 @@ func TestGitPipelineRun(t *testing.T) {
 		repo:     "https://github.com/spring-projects/spring-petclinic",
 		revision: "main",
 	}} {
+		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			ctx := context.Background()
@@ -182,6 +183,7 @@ func TestGitPipelineRunFail(t *testing.T) {
 		name:       "invalid httpsproxy",
 		httpsproxy: "invalid.https.proxy.example.com",
 	}} {
+		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			ctx := context.Background()

test/pipelinerun_test.go

@@ -207,9 +207,9 @@ func TestPipelineRun(t *testing.T) {
 	}}
 
 	for i, td := range tds {
+		i := i   // capture range variable
+		td := td // capture range variable
 		t.Run(td.name, func(t *testing.T) {
-			td := td
-
 			t.Parallel()
 			ctx := context.Background()
 			ctx, cancel := context.WithCancel(ctx)

test/v1alpha1/cancel_test.go

@@ -41,6 +41,7 @@ func TestTaskRunPipelineRunCancel(t *testing.T) {
 	// on failure, to ensure that cancelling the PipelineRun doesn't cause
 	// the retrying TaskRun to retry.
 	for _, numRetries := range []int{0, 1} {
+		numRetries := numRetries // capture range variable
 		t.Run(fmt.Sprintf("retries=%d", numRetries), func(t *testing.T) {
 			ctx := context.Background()
 			ctx, cancel := context.WithCancel(ctx)

test/v1alpha1/git_checkout_test.go

@@ -94,6 +94,7 @@ func TestGitPipelineRun(t *testing.T) {
 		repo:     "https://github.com/spring-projects/spring-petclinic",
 		revision: "main",
 	}} {
+		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			ctx := context.Background()
@@ -180,6 +181,7 @@ func TestGitPipelineRunFail(t *testing.T) {
 		name:       "invalid httpsproxy",
 		httpsproxy: "invalid.https.proxy.example.com",
 	}} {
+		tc := tc // capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			ctx := context.Background()

test/v1alpha1/pipelinerun_test.go

@@ -145,8 +145,9 @@ func TestPipelineRun(t *testing.T) {
 	}}
 
 	for i, td := range tds {
+		i := i   // capture range variable
+		td := td // capture range variable
 		t.Run(td.name, func(t *testing.T) {
-			td := td
 			t.Parallel()
 			ctx := context.Background()
 			ctx, cancel := context.WithCancel(ctx)