Skip to content

Commit

Permalink
Keep Pipeline.status field for backward compatibility 👾
Browse files Browse the repository at this point in the history
They are not used, and shouldn't be there, but client that have
previous version of this struct would fail targeting the API.

This is a *partial* revert of #1640, as it doesn't reintroduce the
`UpdateStatus` generation.

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester committed Dec 18, 2019
1 parent bf498e7 commit 1e01a4b
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 0 deletions.
13 changes: 13 additions & 0 deletions pkg/apis/pipeline/v1alpha1/pipeline_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,19 @@ type Pipeline struct {
// Spec holds the desired state of the Pipeline from the client
// +optional
Spec PipelineSpec `json:"spec"`

// Status is deprecated.
// It usually is used to communicate the observed state of the Pipeline from
// the controller, but was unused as there is no controller for Pipeline.
// +optional
Status *PipelineStatus `json:"status,omitempty"`
}

// PipelineStatus does not contain anything because Pipelines on their own
// do not have a status, they just hold data which is later used by a
// PipelineRun.
// Deprecated
type PipelineStatus struct {
}

func (p *Pipeline) PipelineMetadata() metav1.ObjectMeta {
Expand Down
21 changes: 21 additions & 0 deletions pkg/apis/pipeline/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1e01a4b

Please sign in to comment.