From 6bbd47f5cbd9e754e0b0d7ab7d2a11850d4275fd Mon Sep 17 00:00:00 2001 From: Vincent Demeester Date: Thu, 6 Feb 2020 09:11:42 +0100 Subject: [PATCH] =?UTF-8?q?linting:=20show=20all=20the=20issues=20?= =?UTF-8?q?=F0=9F=91=BF?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit By default `golangci-lint` shows only a given number of issues (to not overload the user with information if there is to much to fix). On the CI we should display all of them. Signed-off-by: Vincent Demeester --- test/presubmit-tests.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/presubmit-tests.sh b/test/presubmit-tests.sh index 2042ab57201..956cdb4db1a 100755 --- a/test/presubmit-tests.sh +++ b/test/presubmit-tests.sh @@ -30,7 +30,8 @@ source $(git rev-parse --show-toplevel)/vendor/github.com/tektoncd/plumbing/scri function post_build_tests() { header "running golangci-lint" - golangci-lint run --deadline 5m + # deadline of 5m, and show all the issues + golangci-lint run --max-issues-per-linter=0 --max-same-issues=0 --deadline 5m } # We use the default build, unit and integration test runners.