-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow environment variables to be added to git-init containers #1328
Comments
/kind feature So this is doable using |
The git clone step isn't run as an init container, but it is an internal step added by the git resource. |
Hi |
Also waiting on this, our Corp uses our own CA to sign the Git repo certificate. Our machines and servers all have this CA loaded, but I can't find a reasonable way to make Jenkins-X work with this. |
For sslVerify specifically we already have that parameterized. It's the When |
Fantastic news... now... can I figure out where to configure that in Jenkins-X... 🤓 |
I'm going to close this as fixed. I believe it's very closely related to #1663 which is now supported thanks to @pritidesai ! |
Expected Behavior
Provide some way (e.g. a ConfigMap?) to be able to add additional environment variables to the
git-init
container stepActual Behavior
Some folks are evaluating Jenkins X + tekton on an internal gitlab which doesn't have a proper public certificate and the first git-init step generated by tekton is failing with
SSL certificate problem: unable to get local issuer certificate
errors.It would be good to be able to configure tekton to add an environment variable to this step - e.g.
GIT_SSL_NO_VERIFY=true
. From noodling the code I don't see a way to add environment variables without hacking the go source.I guess a workaround for now is to build a custom
git-init
image with different env vars inside; but would be nice to make this more easily configurableThe text was updated successfully, but these errors were encountered: