Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PullRequest update fails if there are no comments (or labels or statuses) #1665

Closed
bigkevmcd opened this issue Dec 2, 2019 · 1 comment · Fixed by #1666
Closed

PullRequest update fails if there are no comments (or labels or statuses) #1665

bigkevmcd opened this issue Dec 2, 2019 · 1 comment · Fixed by #1666
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@bigkevmcd
Copy link
Member

Expected Behavior

The pullrequest pipeline output should upload the other configuration items if no comments are written out.

This is happening for a PR with no comments, or labels or previous statuses.

Actual Behavior

It fails early if the comments directory doesn't exist e.g.

{"level":"fatal","ts":1575322816.9789624,"logger":"fallback-logger","caller":"pullrequest-init/main.go:59","msg":"open /workspace/output/pr/comments: no such file or directory","stacktrace":"main.main\n\t/workspace/go/src/github.com/tektoncd/pipeline/cmd/pullrequest-init/main.go:59\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:200"}

https://github.com/tektoncd/pipeline/blob/master/cmd/pullrequest-init/disk.go#L234

Steps to Reproduce the Problem

  1. Create a taskrun with a type: pullrequest output
  2. Write a status to /workspace/pr/status/test.json
  3. Run the task, and it will fail.

Additional Info

@vdemeester
Copy link
Member

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants