error in pipelineruns with spec.volumes[2].name longer than 63 characters

[dibbles]

Expected Behavior

Using a valid service account name and secret name, I expect my pipelinerun to function successfully as in v0.9.0

Actual Behavior

After #1701 the follwing error is seen:

[spec.volumes[2].name: Invalid value: "tekton-internal-secret-volume-tekton-webhooks-extension-dockercfg-s74m2": must be no more than 63 characters

I think this is due to the removal of code that previously restricted the length of the name of the volume mounts. If my digging in the code is correct, my suspicion is around ...

Previously in cred-init.go

 name := names.SimpleNameGenerator.RestrictLengthWithRandomSuffix(fmt.Sprintf("secret-volume-%s", secret.Name))

Now

 name := fmt.Sprintf("tekton-internal-secret-volume-%s", secret.Name)

Steps to Reproduce the Problem

1. create a service account patched with an awfully long secret name (e.g. tekton-webhooks-extension-dockercfg-s74m2)
2. use this service account to run your pipelinerun with dynamic volume provisioning enabled

Additional Info

[imjasonh]

/assign