Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to skip ssl verification in the pull request pipeline resource #1880

Closed
dibbles opened this issue Jan 16, 2020 · 4 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dibbles
Copy link
Member

dibbles commented Jan 16, 2020

Expected Behavior

I should be able to use the pull request pipeline resource in conjunction with a self hosted git server (e.g Gitlab) with a self signed certificate for testing.

Actual Behavior

The pullrequest pipelineresource code provides no mechanism by which to create a client with tls insecureSkipVerify set to true.

Steps to Reproduce the Problem

  1. Create and use a pull request pipelineresource against a git server with a self signed certificate

Additional Info

@dibbles
Copy link
Member Author

dibbles commented Jan 16, 2020

/assign

@dibbles
Copy link
Member Author

dibbles commented Jan 16, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 16, 2020
@dibyom
Copy link
Member

dibyom commented Mar 12, 2020

@dibbles Now what #1881 is merged, can we close this or is there more work remaining?

@dibbles
Copy link
Member Author

dibbles commented Mar 18, 2020

ah yes.... good spot! Closing.

@dibbles dibbles closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants