Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When cancel taskRun, the pipelineRun state should be Cancelled, not Failed. #1900

Closed
assertion opened this issue Jan 19, 2020 · 1 comment · Fixed by #1989
Closed

When cancel taskRun, the pipelineRun state should be Cancelled, not Failed. #1900

assertion opened this issue Jan 19, 2020 · 1 comment · Fixed by #1989
Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@assertion
Copy link
Contributor

Expected Behavior

When I change the state of a taskRun to TaskRunCancelled, the state of pipelineRun should be PipelineRunCancelled. And the state of taskRun and pipelineRun will be consistent.

Actual Behavior

Now if I change the taskRun to Cancelled, the pipelineRun state will be changed to Failure.
In pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go, there's IsDone, isFailure, isSuccessfully, isSkipped functions to check and calculate the state of pipelineRun, but there's no something like isCancelled function.

Steps to Reproduce the Problem

  1. Create a pipelineRune with some taskRuns.
  2. Cancel one running taskRun by updating its spec to mark it as cancelled. Cancelling a TaskRun
  3. Watch the state of pipelineRun.

Additional Info

@vdemeester
Copy link
Member

/kind feature
/area api

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. area/api Indicates an issue or PR that deals with the API. labels Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants