CreateContainerConfigError pods doesn't set the task as failed

[chmouel]

Expected Behavior

Should be set as failed

Actual Behavior

Gets into a forever Pending mode :

simple-run-check-code-qp4p9                   Unknown     Pending     3m30s

Steps to Reproduce the Problem

Create a pulllrequest resource with an invalid secret reference which should create a pod with a CreateContainerConfigError :

      "image": "quay.io/openshift-pipeline/nightly:pullrequest-init",
      "imageID": "",
      "lastState": {},
      "name": "step-pr-source-pr-6cwnv",
      "ready": false,
      "restartCount": 0,
      "started": false,
      "state": {
        "waiting": {
          "message": "secret \"github-secrets\" not found",
          "reason": "CreateContainerConfigError"
        }
      }
    },

the status is in pedning running :

[
  {
    "lastTransitionTime": "2020-01-20T14:29:10Z",
    "message": "build step \"step-pr-source-pr-6cwnv\" is pending with reason \"secret \\\"github-secrets\\\" not found\"",
    "reason": "Pending",
    "status": "Unknown",
    "type": "Succeeded"
  }
]

Additional Info

[chmouel]

/kind bug

[chmouel]

/assign @vincent-pli

[vdemeester]

#1097 got fixed, this can be closed
/close

[tekton-robot]

@vdemeester: Closing this issue.

In response to this:

#1097 got fixed, this can be closed
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.