Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e Test for Having a LimitRange #2071

Closed
danielhelfand opened this issue Feb 19, 2020 · 4 comments · Fixed by #2302
Closed

Add e2e Test for Having a LimitRange #2071

danielhelfand opened this issue Feb 19, 2020 · 4 comments · Fixed by #2302
Assignees
Labels
area/testing Issues or PRs related to testing

Comments

@danielhelfand
Copy link
Member

#2020 added the ability for TaskRuns to apply a LimitRange minimum for container resource requests if a LimitRange container minimum in present in the namespace where the TaskRun is running. There should be a test for running a PipelineRun/TaskRun in a namespace with a LimitRange container minimum specified.

This would require a namespace to be created and adding a LimitRange to that namespace. Both a PipelineRun and independent TaskRun should be able to run and succeed while running in the namespace with the LimitRange.

@dibyom
Copy link
Member

dibyom commented Feb 19, 2020

/area testing

@tekton-robot tekton-robot added the area/testing Issues or PRs related to testing label Feb 19, 2020
@danielhelfand
Copy link
Member Author

/assign

@vdemeester
Copy link
Member

@danielhelfand what is the status ? 👼

@danielhelfand
Copy link
Member Author

@vdemeester I am going to change the plan from the original issue description and add a go test for this instead. Can look to get a pr in this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing
Projects
None yet
4 participants