Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContainerState to SidecarState #2074

Closed
danielhelfand opened this issue Feb 19, 2020 · 1 comment · Fixed by #2075
Closed

Add ContainerState to SidecarState #2074

danielhelfand opened this issue Feb 19, 2020 · 1 comment · Fixed by #2075
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@danielhelfand
Copy link
Member

danielhelfand commented Feb 19, 2020

Related issue is tkn taskrun describe, doesn't show any sidecar info #655 in the CLI repository.

The gist of the issue is that tkn tr desc doesn't show any information about sidecar containers that are part of a TaskRun. It would be nice to be able to show as part of a TaskRun description the name and state of the sidecar container.

This would also provide more information via a kubectl describe taskrun command.

The problem is that the SidecarState struct only has Name and ImageID at this time. It would be great to add the ContainerState similar to what is done for StepState.

Expected Behavior

I should be able to see the status of sidecar containers that are part of a TaskRun similar to steps.

Actual Behavior

Only the Name and ImageID are available under the Status of a TaskRun.

Additional Info

Original pr to introduce this was #1515

@ghost ghost added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 19, 2020
@danielhelfand
Copy link
Member Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant