Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks with results fail if when docker containers do not run as root #2131

Closed
kh-sonrai opened this issue Mar 2, 2020 · 4 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kh-sonrai
Copy link

The /tekton/results directory is only writable by root, so images that do not run as root fail to create the directory. If any such docker image is included in a task, the task will fail with the following error if a results section is included in the task spec:
Error creating the results directory: mkdir /tekton/results: permission denied

if err := os.MkdirAll(pipeline.DefaultResultPath, 0755); err != nil {

@vdemeester
Copy link
Member

/kind bug
/cc @othomann @sbwsg

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 2, 2020
@othomann
Copy link
Contributor

othomann commented Mar 2, 2020

I will be pleased to fix it as soon as I am done with the PR for pipeline results.

othomann added a commit to othomann/pipeline that referenced this issue Mar 2, 2020
@othomann
Copy link
Contributor

othomann commented Mar 2, 2020

I have a fix for it, but I am not sure how to add a regression test for it.

othomann added a commit to othomann/pipeline that referenced this issue Mar 2, 2020
othomann added a commit to othomann/pipeline that referenced this issue Mar 3, 2020
othomann added a commit to othomann/pipeline that referenced this issue Mar 3, 2020
othomann added a commit to othomann/pipeline that referenced this issue Mar 3, 2020
@ghost
Copy link

ghost commented Mar 3, 2020

Closing as fixed by #2143

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants